Add copilot review instructions #2170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
add-copilot-review-instructions
branch
from
d017a25 to
ee36ce4
Compare
SylvainJuge
approved these changes
Aug 26, 2025
|
|
||
| ### Critical Areas | ||
|
|
||
| - **Public APIs**: Changes affect downstream users and require careful review |
Contributor
There was a problem hiding this comment.
[question] do we have an easy way to know when the public API changes in a given PR ?
laurit
approved these changes
Aug 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also revamped the style guide since the copilot review instructions rely heavily on those.
I will probably copy many of the style guide improvements here over to the instrumentation repo.
It seems we need to have it in both repos though, as Copilot reviewer won't follow an external link in the copilot-instructions.md file.
Also simplified CONTRIBUTING.md and README.md a bit.